Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to detect if client is running in a Vmware to disable graphic acceleration #7687

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Attempt to detect if client is running in a Vmware to disable graphic acceleration #7687

merged 2 commits into from
Feb 12, 2025

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Dec 19, 2024 •
edited
Loading

@camilasan camilasan added this to the 3.15.3 milestone Dec 19, 2024
@camilasan camilasan self-assigned this Dec 19, 2024
@camilasan camilasan marked this pull request as draft December 19, 2024 14:49
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7687-76a265c3a9f70c3e6d3bab7f1268416b4aff7fa7-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
12 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@camilasan camilasan mentioned this pull request Dec 22, 2024
Open
8 tasks
@mgallien mgallien modified the milestones: 3.15.3, 3.16.0 Jan 3, 2025
@camilasan camilasan marked this pull request as ready for review February 5, 2025 15:03
mgallien
mgallien requested changes Feb 12, 2025
View reviewed changes
src/gui/application.cpp Outdated Show resolved Hide resolved
camilasan and others added 2 commits February 12, 2025 09:54
@camilasan @mgallien
Detect if it is running in a Vmware or being access via RDP to disabl…
5275a91 
…e graphic acceleration.

There has been reports of the client crashing in a VMware or being accessed via RDP
starting with 3.15.0 due to the client's use of graphic acceleration.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@mgallien
use qputenv to modify the running process environment
4544c2f 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien merged commit 8fd3769 into master Feb 12, 2025
10 of 14 checks passed
@mgallien mgallien deleted the bugfix/vmware branch February 12, 2025 08:54
@github-actions GitHub Actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-7687.zip

SHA256 checksum: dbbefc18ef572a19c98ee8d1042202df7b757023de52b52806449d9eaa212c1b

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@nilsding nilsding Awaiting requested review from nilsding

Assignees

@camilasan camilasan

Labels
None yet
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@camilasan @nextcloud-desktop-bot @mgallien